LeAn issueshttps://git.devdroplets.com/open-ict/lean/-/issues2021-05-25T16:28:18Zhttps://git.devdroplets.com/open-ict/lean/-/issues/171Follow-up from "Feature/#153 review overhaul"2021-05-25T16:28:18ZRyanryan@devdroplets.comFollow-up from "Feature/#153 review overhaul"The following discussions from !83 should be addressed:
- [x] @Ryan started a [discussion](https://git.devdroplets.com/open-ict/lean/-/merge_requests/83#note_5749):
> `let color = green;`
> Dan hoef je de laatste else statemen...The following discussions from !83 should be addressed:
- [x] @Ryan started a [discussion](https://git.devdroplets.com/open-ict/lean/-/merge_requests/83#note_5749):
> `let color = green;`
> Dan hoef je de laatste else statement niet :)
- [ ] @Ryan started a [discussion](https://git.devdroplets.com/open-ict/lean/-/merge_requests/83#note_5750):
> ```
> t.inclue
> ? t.split(' - ')[1]
> : shorten(t)
> ```
>
> Split, create a function to retrieve only the first letters of `t` and don't use regex if not neccesary.
- [ ] @Ryan started a [discussion](https://git.devdroplets.com/open-ict/lean/-/merge_requests/83#note_5751):
> COmmented code
- [ ] @Ryan started a [discussion](https://git.devdroplets.com/open-ict/lean/-/merge_requests/83#note_5752):
> Obselete
- [ ] @Ryan started a [discussion](https://git.devdroplets.com/open-ict/lean/-/merge_requests/83#note_5753):
> Still hacky?
- [ ] @Ryan started a [discussion](https://git.devdroplets.com/open-ict/lean/-/merge_requests/83#note_5754):
> ...Space for analytics...
- [ ] @Ryan started a [discussion](https://git.devdroplets.com/open-ict/lean/-/merge_requests/83#note_5755):
> Return statement within an arrow function?
- [ ] @Ryan started a [discussion](https://git.devdroplets.com/open-ict/lean/-/merge_requests/83#note_5756):
> Commented code?
- [ ] @Ryan started a [discussion](https://git.devdroplets.com/open-ict/lean/-/merge_requests/83#note_5757):
> Commented code.
- [ ] @Ryan started a [discussion](https://git.devdroplets.com/open-ict/lean/-/merge_requests/83#note_5758):
> Use [lodash's truncate](https://lodash.com/docs/4.17.15#truncate) for easy readability and less comments.
- [ ] @Ryan started a [discussion](https://git.devdroplets.com/open-ict/lean/-/merge_requests/83#note_5759):
> ```
> const averate = _round(_sum(reviewerScores) / reviewerScores.length, 2)
> ```
> Or even fancier:
> ```
> _(reviewerScores)
> .thru(_.sum)
> .thru(n => n / 2)
> .round(2)
> ```
- [ ] @Ryan started a [discussion](https://git.devdroplets.com/open-ict/lean/-/merge_requests/83#note_5761): (+1 comment)
> Make a seprate component maybe?https://git.devdroplets.com/open-ict/lean/-/issues/170Fix reviews given2021-05-25T09:32:55ZLuca BergmanFix reviews given> Summary
> ----------
> <!-- Summarize the bug encountered concisely -->
Reviews given gives a list of all assignments including ones that have not been given a review by the user
### Steps to reproduce
Call /api/reviews/gotten endpoint...> Summary
> ----------
> <!-- Summarize the bug encountered concisely -->
Reviews given gives a list of all assignments including ones that have not been given a review by the user
### Steps to reproduce
Call /api/reviews/gotten endpoint
<!-- How one can reproduce the issue - this is very important -->
### Example Project
<!-- If possible, please create an example project here on GitLab.com that exhibits the problematic behavior, and link to it here in the bug report -->
<!-- If you are using an older version of GitLab, this will also determine whether the bug is fixed in a more recent version -->
### What is the current *bug* behavior?
lists all assignments currently seen by lean, assignments that havent been given a review by the user are also seen.
<!-- What actually happens -->
### What is the expected *correct* behavior?
list of assignments that have been given a review by the user excluding ones that haven't received a review from the user
<!-- What you should see instead -->
### Relevant logs and/or screenshots
<!-- Paste any relevant logs - please use code blocks (```) to format console output,
logs, and code as it's tough to read otherwise. -->
### Possible fixes
<!--
If you can, link to the line of code that might be responsible for the problem.
If you know an alternative or solution all together, paste your ideas to help out :)
-->https://git.devdroplets.com/open-ict/lean/-/issues/168Lean Homepage (Lean.reviews)2022-03-30T11:09:46ZKevin de Meijerkevin.demeijer@student.hu.nlLean Homepage (Lean.reviews)> **As a** \
> **I want to** \
> **So that I**
### Extra Description
### Acceptation criteria
- [ ] Live connection
- [ ] Regular ping check
### Assignees
- @kevin.demeijer
###### [This template origin](https://www.atlassian.com/ag...> **As a** \
> **I want to** \
> **So that I**
### Extra Description
### Acceptation criteria
- [ ] Live connection
- [ ] Regular ping check
### Assignees
- @kevin.demeijer
###### [This template origin](https://www.atlassian.com/agile/project-management/user-stories)Version 62021-05-26https://git.devdroplets.com/open-ict/lean/-/issues/167Inventarisation Regular version LeAn2021-05-18T08:33:38ZLuca BergmanInventarisation Regular version LeAnhttps://git.devdroplets.com/open-ict/lean/-/issues/166Fix review suggestions in refactor backend2021-05-17T09:20:19ZLuca BergmanFix review suggestions in refactor backendhttps://git.devdroplets.com/open-ict/lean/-/issues/163Learning authentication in the backend2021-04-22T12:02:58ZLuca BergmanLearning authentication in the backend> **As a** student\
> **I want to** learn to work with authentication in the backend\
> **So that I can** Complete the refactoring of the backend #160
### Extra Description
I am currently not comfortable with working with authenticatio...> **As a** student\
> **I want to** learn to work with authentication in the backend\
> **So that I can** Complete the refactoring of the backend #160
### Extra Description
I am currently not comfortable with working with authentication in a backend. This makes it so that I have a mental block for working on the backend. Therefore I want to learn/ get comfortable working with auth services such as Oauth and passport in the backend. This will relieve my mental blockade and allow me to work harder and faster.
<!--
Some extra description if there is any needed
E.g: The logplower connection should be live with a socket or something
It could be helpful to show examples
-->
### Acceptatiecriteria (Learning Story)
- [x] De reden is duidelijk waarom de learning story is aangemaakt.
- [x] Het leerdoel is duidelijk en haalbaar.
- [ ] De kennis kan worden uitgelegd.
- [ ] De kennis is toegepast binnen de US/ES/RS.
- [ ] Er is een bronnenlijst, per bron is de toegevoegde waarde beschreven.
- [ ] Er zijn aantoonbare resultaten van het leren.
@luca.bergmanLuca BergmanLuca Bergman2021-04-16https://git.devdroplets.com/open-ict/lean/-/issues/162Weird assignment checker errors2021-04-08T09:41:44ZRyanryan@devdroplets.comWeird assignment checker errors> Summary
> ----------
> Assignment checker faults
### Steps to reproduce
1. Open an incorrect assignment
2. View the errors
3. See that reviewers count is too little. Even though it is 200
### What is the current *bug* behavior?
Vie...> Summary
> ----------
> Assignment checker faults
### Steps to reproduce
1. Open an incorrect assignment
2. View the errors
3. See that reviewers count is too little. Even though it is 200
### What is the current *bug* behavior?
View some errors are fuzzy and weird.
### What is the expected *correct* behavior?
Clear errors
### Relevant logs and/or screenshots
![image](/uploads/644f4441882572983896c58ca68e1d91/image.png) \
<small> One of the fuzzy errors </small>
### Possible fixes
<!--
If you can, link to the line of code that might be responsible for the problem.
If you know an alternative or solution all together, paste your ideas to help out :)
-->https://git.devdroplets.com/open-ict/lean/-/issues/157Development database seeder2021-03-29T11:31:06ZLuca BergmanDevelopment database seeder> **As a** Developer \
> **I want to** make a database seeder\
> **So that I** can quickly and automatically generate test data for my development environment
### Extra Description
Plan is to use the record puppeteer function in chrome ...> **As a** Developer \
> **I want to** make a database seeder\
> **So that I** can quickly and automatically generate test data for my development environment
### Extra Description
Plan is to use the record puppeteer function in chrome version 89 and up to automatically add new students and assignments. All text will be generated by an open source ai and requested by an api call.
<!--
Some extra description if there is any needed
E.g: The logplower connection should be live with a socket or something
It could be helpful to show examples
-->
### Acceptation criteria
- [ ] Script that generates all data
- [ ] Script to drop all generated data
<!--
Criterion for acceptance of the User Story
E.g:
- [ ] Live connection
- [ ] Regular ping check
-->
### Assignees
<!--
Everyone that should be assigned listed with
both the label and a mention.
E.g.
- @ryan
- @kevin
- @luca
-->
@luca.bergman @Ryan
###### [This template origin](https://www.atlassian.com/agile/project-management/user-stories)https://git.devdroplets.com/open-ict/lean/-/issues/156Reviewer suggestions notifications2021-03-16T09:57:35ZLuca BergmanReviewer suggestions notifications> **As a** student \
> **I want to** be able to quickly send a notification to a suggested reviewer telling them that I want them to review my product \
> **So that I** can more easily gather reviewers
### Extra Description
Add a button...> **As a** student \
> **I want to** be able to quickly send a notification to a suggested reviewer telling them that I want them to review my product \
> **So that I** can more easily gather reviewers
### Extra Description
Add a button next to a suggested reviewer that will either send them an email via the devdroplets mail server or use a discord bot to send them a message.
The mail server is definitely easier but the general opinion is is that mail is not the right place to send that notification. A discord bot would be harder but a better choice.
A discord bot would also require a user to add their discord handle just like they added their toggl token.
<!--
Some extra description if there is any needed
E.g: The logplower connection should be live with a socket or something
It could be helpful to show examples
-->
### Acceptation criteria
- [ ] Button for sending a notification
- [ ] Bot or script that sends a notification via email or discord
<!--
Criterion for acceptance of the User Story
E.g:
- [ ] Live connection
- [ ] Regular ping check
-->
### Assignees
- @luca.bergman
<!--
Everyone that should be assigned listed with
both the label and a mention.
E.g.
- @ryan
- @kevin
- @luca
-->
###### [This template origin](https://www.atlassian.com/agile/project-management/user-stories)https://git.devdroplets.com/open-ict/lean/-/issues/155Reviewer suggestions more information for suggestions2021-03-22T11:43:56ZLuca BergmanReviewer suggestions more information for suggestions> **As a** User\
> **I want to** see more of the reasons why a user was suggested as a suggested reviewer\
> **So that I** can better pick a reviewer for my product
### Extra Description
More of an excel like table that shows reasons l...> **As a** User\
> **I want to** see more of the reasons why a user was suggested as a suggested reviewer\
> **So that I** can better pick a reviewer for my product
### Extra Description
More of an excel like table that shows reasons like:had a good grade in: hboi1 or is working on grade hboi2 too
<!--
Some extra description if there is any needed
E.g: The logplower connection should be live with a socket or something
It could be helpful to show examples
-->
### Acceptation criteria
<!--
Criterion for acceptance of the User Story
E.g:
- [ ] Live connection
- [ ] Regular ping check
-->
- [ ] More reviewer suggestions information next to suggested reviewer
### Assignees
<!--
Everyone that should be assigned listed with
both the label and a mention.
E.g.
- @ryan
- @kevin
- @luca
-->
- @luca.bergman
###### [This template origin](https://www.atlassian.com/agile/project-management/user-stories)https://git.devdroplets.com/open-ict/lean/-/issues/154Reviewer suggestions more & better suggestions2021-04-30T11:17:31ZLuca BergmanReviewer suggestions more & better suggestions> **As a** User\
> **I want to** receive more suggestions\
> **So that I** can choose between the better ones
### Extra Description
Current if statements usually return either 1 or 2 reviewer suggestions.
This is more often than not too...> **As a** User\
> **I want to** receive more suggestions\
> **So that I** can choose between the better ones
### Extra Description
Current if statements usually return either 1 or 2 reviewer suggestions.
This is more often than not too little as they might be too busy to review it.
An idea would be to incorporate some kind of ai in it that decides to show more the less qualified reviewers it can get. With an included warning ofcourse.
<!--
Some extra description if there is any needed
E.g: The logplower connection should be live with a socket or something
It could be helpful to show examples
-->
### Acceptation criteria
- [ ] More reviewer suggestions
- [ ] Defined minimum of reviewer suggestions/ always show some!
<!--
Criterion for acceptance of the User Story
E.g:
- [ ] Live connection
- [ ] Regular ping check
-->
### Assignees
<!--
Everyone that should be assigned listed with
both the label and a mention.
E.g.
- @ryan
- @kevin
- @luca
-->
- @luca.bergman
###### [This template origin](https://www.atlassian.com/agile/project-management/user-stories)https://git.devdroplets.com/open-ict/lean/-/issues/152Reviewer suggestions research2021-04-30T11:19:33ZLuca BergmanReviewer suggestions research> **As a researcher** \
> **I want to know** how I can improve the reviewer suggestion\
> **So that I can** improve the user experience
### Extra Description
Reviewer suggestions is a tool that does not entice itself to be used. It nee...> **As a researcher** \
> **I want to know** how I can improve the reviewer suggestion\
> **So that I can** improve the user experience
### Extra Description
Reviewer suggestions is a tool that does not entice itself to be used. It needs to either offer more features, have a better control panel, show a better list of possible reviewers or be able to send a notification.
<!--
Extra description on what you want to learn about and why
E.g: I want to learn about kubernetes so that I can create a distributed micro-service
-->
### Knowledge criteria
- [ ] Multiple ways to improve the reviewer suggestion as to entice users to use it
- [ ] Research if people want push notifications
- [ ] Research if people want a new tab for reviewer suggestions
<!--
Criterion for acceptance. When do you think you're knowledgable enough.
E.g:
- [ ] Kubernetes startup
- [ ] Kubernetes simple network
- [ ] Kubernetes configuration best practices
-->
###### [This template origin](https://www.atlassian.com/agile/project-management/user-stories)https://git.devdroplets.com/open-ict/lean/-/issues/150Assessment print out2021-05-26T08:37:49ZKevin de Meijerkevin.demeijer@student.hu.nlAssessment print out> **As a teacher** \
> **I want to be able to view a print out of the assessment grade** \
> **So that I will be able to grade students in canvas**
### Extra Description
The teacher must fill in a grade for each semester so students w...> **As a teacher** \
> **I want to be able to view a print out of the assessment grade** \
> **So that I will be able to grade students in canvas**
### Extra Description
The teacher must fill in a grade for each semester so students will be able to complete their study.
### Extra Visualistion
| Student nr. | Naam | Assessmentcijfer | Student | HBOi |
|-------------|-------|------------------|---------|------------|
| 123456 | Ryan | 10 | 9,3 | SRE2 / GA3 |
| 223512 | Kevin | 9,4 | 5,1 | GR3 / SA1 |
| 912336 | Luca | 5,5 | 7,3 | IA2 / OO2 |
### Acceptation criteria
- [ ] Students that a Teacher has access to.
- [ ] Table with the assessment of all their students.
- [ ] Viable information that is noted above.
### Assignees
Currently no-one
###### [This template origin](https://www.atlassian.com/agile/project-management/user-stories)Version 62021-04-02https://git.devdroplets.com/open-ict/lean/-/issues/148More/ better wordcloud data2021-03-11T15:57:50ZLuca BergmanMore/ better wordcloud data> **As a researcher** \
> **I want to know** in which ways I can improve the word gathering for the wordcloud \
> **So that I can** show better results in the wordcloud
### Extra Description
<!--
Extra description on what you want to l...> **As a researcher** \
> **I want to know** in which ways I can improve the word gathering for the wordcloud \
> **So that I can** show better results in the wordcloud
### Extra Description
<!--
Extra description on what you want to learn about and why
E.g: I want to learn about kubernetes so that I can create a distributed micro-service
-->
I want to learn about Regex and Natural language processing in python so that I can filter out words and select good words to return
### Knowledge criteria
- [ ] List of ways that I can improve the wordcloud data
- [ ] List of places that I can learn the ways to improve the wordcloud data
<!--
Criterion for acceptance. When do you think you're knowledgable enough.
E.g:
- [ ] Kubernetes startup
- [ ] Kubernetes simple network
- [ ] Kubernetes configuration best practices
-->
###### [This template origin](https://www.atlassian.com/agile/project-management/user-stories)https://git.devdroplets.com/open-ict/lean/-/issues/147HBOi / LeAn Inzage Docenten2021-03-10T09:37:41ZKevin de Meijerkevin.demeijer@student.hu.nlHBOi / LeAn Inzage Docenten### Problem to solve
Teachers currently have to ask a student to be able to see their Lean Dashboard.
### Intended users
The teacher / mentor
### Further details
<!-- Include use cases, benefits, and/or goals (contributes to our vis...### Problem to solve
Teachers currently have to ask a student to be able to see their Lean Dashboard.
### Intended users
The teacher / mentor
### Further details
<!-- Include use cases, benefits, and/or goals (contributes to our vision?) -->
### Links / referenceshttps://git.devdroplets.com/open-ict/lean/-/issues/146Follow-up from "Feature/#129 word cloud profile"2021-03-08T11:31:10ZRyanryan@devdroplets.comFollow-up from "Feature/#129 word cloud profile"The following discussion from !77 should be addressed:
- [ ] @Ryan started a [discussion](https://git.devdroplets.com/open-ict/lean/-/merge_requests/77#note_4696):
> Instead of using `temp{variable}`, use the object `wordcloudSett...The following discussion from !77 should be addressed:
- [ ] @Ryan started a [discussion](https://git.devdroplets.com/open-ict/lean/-/merge_requests/77#note_4696):
> Instead of using `temp{variable}`, use the object `wordcloudSettings` directly to access their descending children.
> Makes code readability better.
>
> I.e:
> ```javascript
> if (wordcloudSettings.deletedWords) setDeletedWords(wordcloudSettings.deletedWords);
> ```https://git.devdroplets.com/open-ict/lean/-/issues/145Follow-up from "WIP: Feature/#129 word cloud profile"2021-03-08T11:29:29ZRyanryan@devdroplets.comFollow-up from "WIP: Feature/#129 word cloud profile"The following discussion from !77 should be addressed:
- [ ] @Ryan started a [discussion](https://git.devdroplets.com/open-ict/lean/-/merge_requests/77#note_4699): (+2 comments)
> Let's import lodash entirely and use tree shaking ...The following discussion from !77 should be addressed:
- [ ] @Ryan started a [discussion](https://git.devdroplets.com/open-ict/lean/-/merge_requests/77#note_4699): (+2 comments)
> Let's import lodash entirely and use tree shaking ([some info](https://www.dwightwatson.com/posts/allow-treeshaking-with-lodash))https://git.devdroplets.com/open-ict/lean/-/issues/144Bug: date range doesn't consider today2021-03-08T12:15:15ZNikki WestenborgBug: date range doesn't consider today> Summary
> ----------
> When selecting a date range in the review tab, it does not count the reviews you got today.
### Steps to reproduce
Have someone review you and then go to the LeAn review tab and change the date range for incomi...> Summary
> ----------
> When selecting a date range in the review tab, it does not count the reviews you got today.
### Steps to reproduce
Have someone review you and then go to the LeAn review tab and change the date range for incoming reviews (including today of course). If you don't change the date range, you can see that review.
### What is the current *bug* behavior?
it won't show the reviews from today
### What is the expected *correct* behavior?
when today is selected in the data range, i want to see todays reviews.https://git.devdroplets.com/open-ict/lean/-/issues/142Reviewer suggestions AI2021-02-08T09:38:40ZLuca BergmanReviewer suggestions AIhttps://git.devdroplets.com/open-ict/lean/-/issues/113Sentiment Detector2021-02-08T09:26:28ZAswin ToniSentiment Detector> **As a User** \
> **I want to be able to view the sentiment of my review** \
> **So** I can adjust the phrasing accordingly
### Extra Description
Make something similar to grammarly's tone detector with machine learning and a rule-set...> **As a User** \
> **I want to be able to view the sentiment of my review** \
> **So** I can adjust the phrasing accordingly
### Extra Description
Make something similar to grammarly's tone detector with machine learning and a rule-set. The application should be able to recognize the sentiment of a given text based on analyzing aspects in your word choice, phrasing, punctuation, and capitalization.
### Acceptation criteria
Criterion for acceptance of the User Story
- [ ] The code can detect the tone of a given text at a reasonable success rate providing an indicator of the sentiment of their reviews to students.
### Assignees
- @daud